We decided to revert the testutil change that made our util functions less error-prone, but created a lot of work for our downstream users. Apologies for the pain! This revert should not cause any major breaking change, even if you already did the work--unless you depend on the exact error message.
Going forward, we plan to reinforce our release testing strategy [1],[2] and deliver an enhanced testutil package/module with more flexible and safer APIs.
[BUGFIX] testutil: Reverted #1424; functions using compareMetricFamilies are (again) only failing if filtered metricNames are in the expected input. #1645
Configuration
📅Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕Ignore: Close this PR and you won't be reminded about this update again.
If you want to rebase/retry this PR, check this box
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) | require | patch | `v1.20.4` -> `v1.20.5` |
---
### Release Notes
<details>
<summary>prometheus/client_golang (github.com/prometheus/client_golang)</summary>
### [`v1.20.5`](https://github.com/prometheus/client_golang/releases/tag/v1.20.5): / 2024-10-15
[Compare Source](https://github.com/prometheus/client_golang/compare/v1.20.4...v1.20.5)
We decided to revert [the `testutil` change](https://github.com/prometheus/client_golang/pull/1424) that made our util functions less error-prone, but created a lot of work for our downstream users. Apologies for the pain! This revert should not cause any major breaking change, even if you already did the work--unless you depend on the [exact error message](https://github.com/grafana/mimir/pull/9624#issuecomment-2413401565).
Going forward, we plan to reinforce our release testing strategy [\[1\]](https://github.com/prometheus/client_golang/issues/1646),[\[2\]](https://github.com/prometheus/client_golang/issues/1648) and deliver an enhanced [`testutil` package/module](https://github.com/prometheus/client_golang/issues/1639) with more flexible and safer APIs.
Thanks to [@​dashpole](https://github.com/dashpole) [@​dgrisonnet](https://github.com/dgrisonnet) [@​kakkoyun](https://github.com/kakkoyun) [@​ArthurSens](https://github.com/ArthurSens) [@​vesari](https://github.com/vesari) [@​logicalhan](https://github.com/logicalhan) [@​krajorama](https://github.com/krajorama) [@​bwplotka](https://github.com/bwplotka) who helped in this patch release! 🤗
##### Changelog
\[BUGFIX] testutil: Reverted [#​1424](https://github.com/prometheus/client_golang/issues/1424); functions using compareMetricFamilies are (again) only failing if filtered metricNames are in the expected input. [#​1645](https://github.com/prometheus/client_golang/issues/1645)
</details>
---
### Configuration
📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xMjQuMCIsInVwZGF0ZWRJblZlciI6IjM4LjEyNC4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbXX0=-->
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
This PR contains the following updates:
v1.20.4->v1.20.5Release Notes
prometheus/client_golang (github.com/prometheus/client_golang)
v1.20.5: / 2024-10-15Compare Source
We decided to revert the
testutilchange that made our util functions less error-prone, but created a lot of work for our downstream users. Apologies for the pain! This revert should not cause any major breaking change, even if you already did the work--unless you depend on the exact error message.Going forward, we plan to reinforce our release testing strategy [1],[2] and deliver an enhanced
testutilpackage/module with more flexible and safer APIs.Thanks to @dashpole @dgrisonnet @kakkoyun @ArthurSens @vesari @logicalhan @krajorama @bwplotka who helped in this patch release! 🤗
Changelog
[BUGFIX] testutil: Reverted #1424; functions using compareMetricFamilies are (again) only failing if filtered metricNames are in the expected input. #1645
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.